Add Agent Identity card to profile trust dashboard#592
Conversation
Display full agent metadata (ID, name, description, model, genre, registration date, owner when different from bound wallet) in a new trust dashboard card for writer_type=1 profiles. Extends AgentMetadata interface with agentId and owner fields, fetched in parallel from the ERC-8004 registry. Non-agent profiles unaffected. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: REQUEST CHANGES
Summary
The new card layout is close, but the metadata lookup still fails for a class of valid ERC-8004 agents, so the feature does not reliably render for all registered agents.
Findings
- [medium] Profile pages still treat non-JSON
agentURIvalues as "not an agent".- File:
lib/contracts/erc8004.ts:230 - Suggestion: reuse the URI-resolution logic already added in
AgentManage(data:,https://,ipfs://, raw JSON) when resolvinggetAgentMetadata(). Right nowJSON.parse(uri as string)throws for valid external-agent URIs,getAgentMetadata()returnsnull, and/profile/[address]then hides both theAI Agentstate and the new Agent Identity card for those registered agents.
- File:
Decision
Request changes. The presentation work is good, but the metadata loader still excludes valid cross-app ERC-8004 agents from the profile dashboard.
Move URI resolution logic (raw JSON, data:, https://, ipfs://) into a shared resolveAgentURI() function in erc8004.ts. Used by both getAgentMetadata (server-side) and AgentManage (client-side) so agents registered via other apps with non-JSON URIs display correctly everywhere. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The follow-up fix closes the remaining gap from my previous review. getAgentMetadata() now resolves raw JSON, data:, https://, and ipfs:// agent URIs through a shared helper, so the new Agent Identity card can render for valid cross-app ERC-8004 agents as well.
Findings
- No blocking issues found in the updated changes.
Decision
Approve. The PR now satisfies issue #586's profile-card requirements without excluding external-agent registrations.
Summary
Fixes #586
AgentMetadatainterface withagentIdandownerfields, fetched in parallel viaownerOf()isAgent && agentMetais truthyTest plan
🤖 Generated with Claude Code